netdev - Re: [PATCH net-next 1/2] net: dsa: realtek: Rename bogus RTL8368S variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <surgf4zypwwthiulvmxxj2bbijvj6bxivcjyffiduyjlt22okm@borejh2vkgpl>
Date: Sun, 10 Dec 2023 13:00:30 +0000
From: Alvin Šipraga <ALSI@...g-olufsen.dk>
To: Linus Walleij <linus.walleij@...aro.org>
CC: Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>,
	Vladimir Oltean <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] net: dsa: realtek: Rename bogus RTL8368S
 variable

On Sat, Dec 09, 2023 at 11:37:34PM +0100, Linus Walleij wrote:
> Rename the register name to RTL8366RB instead of the bogus
> RTL8368S (internal product name?)
> 
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

Reviewed-by: Alvin Šipraga <alsi@...g-olufsen.dk>

> ---
>  drivers/net/dsa/realtek/rtl8366rb.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/dsa/realtek/rtl8366rb.c b/drivers/net/dsa/realtek/rtl8366rb.c
> index b39b719a5b8f..887afd1392cb 100644
> --- a/drivers/net/dsa/realtek/rtl8366rb.c
> +++ b/drivers/net/dsa/realtek/rtl8366rb.c
> @@ -117,10 +117,11 @@
>  	RTL8366RB_STP_STATE((port), RTL8366RB_STP_MASK)
>  
>  /* CPU port control reg */
> -#define RTL8368RB_CPU_CTRL_REG		0x0061
> -#define RTL8368RB_CPU_PORTS_MSK		0x00FF
> +#define RTL8366RB_CPU_CTRL_REG		0x0061
> +#define RTL8366RB_CPU_PORTS_MSK		0x00FF
>  /* Disables inserting custom tag length/type 0x8899 */
> -#define RTL8368RB_CPU_NO_TAG		BIT(15)
> +#define RTL8366RB_CPU_NO_TAG		BIT(15)
> +#define RTL8366RB_CPU_TAG_SIZE		4
>  
>  #define RTL8366RB_SMAR0			0x0070 /* bits 0..15 */
>  #define RTL8366RB_SMAR1			0x0071 /* bits 16..31 */
> @@ -912,10 +913,10 @@ static int rtl8366rb_setup(struct dsa_switch *ds)
>  
>  	/* Enable CPU port with custom DSA tag 8899.
>  	 *
> -	 * If you set RTL8368RB_CPU_NO_TAG (bit 15) in this registers
> +	 * If you set RTL8366RB_CPU_NO_TAG (bit 15) in this register
>  	 * the custom tag is turned off.
>  	 */
> -	ret = regmap_update_bits(priv->map, RTL8368RB_CPU_CTRL_REG,
> +	ret = regmap_update_bits(priv->map, RTL8366RB_CPU_CTRL_REG,
>  				 0xFFFF,
>  				 BIT(priv->cpu_port));
>  	if (ret)
> 
> -- 
> 2.34.1
>