netdev - [PATCH] net: netperf TCP_CRR test fails in bonding interfaces(mode 0)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHnGgyF-oAnCd+NdvdZVzhE4VZLnK+BcVBH3gQqm9v0Q1s_QGw@mail.gmail.com>
Date: Sun, 10 Dec 2023 23:16:20 +0800
From: ditang chen <ditang.c@...il.com>
To: netdev@...r.kernel.org
Subject: [PATCH] net: netperf TCP_CRR test fails in bonding interfaces(mode 0)

Reproduce
1. client/server:
# modprobe bonding
# ifconfig enp1s3 down
# ifconfig enp2s3 down
# echo "+bond0" > /sys/class/net/bonding_masters
# edho "enp1s3" > /sys/class/net/bond0/bonding/slaves
# edho "enp2s3" > /sys/class/net/bond0/bonding/slaves
# ifconfig bond0 up

2. server
# ifconfig bond0 192.168.50.101
# netserver -D -d -f

3. client
# ifconfig bond0 192.168.50.100
# netperf -t TCP_CRR -H 192.168.50.101 -l 3600

netperf may terminated with "netperf:send_omni:recv_data failed:
Connection reset by peer".
the client correctly establishes connection and then send its
data(psh+ack), but if the server process the data(psh+ack) before the
ack, and then server side just resets connection.

---
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 8afb0950a697..630bbe78539f 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -6502,8 +6502,11 @@ int tcp_rcv_state_process(struct sock *sk,
struct sk_buff *skb)
                goto discard;

        case TCP_LISTEN:
-               if (th->ack)
+               if (th->ack) {
+                       if (th->psh)
+                               goto discard;
                        return 1;
+               }