netdev - Re: selftest fib_nexthop_multiprefix failed due to route mismatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZXbUzpDGErm-JXSC@Laptop-X1>
Date: Mon, 11 Dec 2023 17:22:22 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: David Ahern <dsahern@...nel.org>
Cc: netdev@...r.kernel.org
Subject: Re: selftest fib_nexthop_multiprefix failed due to route mismatch

On Fri, Dec 08, 2023 at 12:21:55PM -0700, David Ahern wrote:
> > Hi David,
> > 
> > I re-test this on 6.4.0 and it also failed. So this looks like an env issue
> > on your side?
> > 
> > # uname -r
> > 6.4.0
> > # ./fib_nexthop_multiprefix.sh
> > TEST: IPv4: host 0 to host 1, mtu 1300                              [ OK ]
> > TEST: IPv6: host 0 to host 1, mtu 1300                              [FAIL]
> > 
> > And from the test result, it looks we should receive the Packet too big message
> > from r1. So look the current checking is incorrect and the "from ::" checking
> > should be removed.
> > 
> > Please fix me if I missed anything?
> > 
> 
> I ran it in a ubuntu 20.04 VM. Do not recall any specific sysctl
> settings to the VM, but maybe something is different between U20.04 and
> your OS

OK, I got the reason. The "from ::1" is put in rt6_fill_node()
when CONFIG_IPV6_SUBTREES is enabled. I will fix this grep issue
in my next selftests namespace conversion patch set.

Thanks
Hangbin