netdev - Re: [RFT PATCH 1/2] stmmac: dwmac-loongson: drop useless check for compatible fallback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <9bdcd491-5ee5-48b3-844c-d6c0092bfc73@app.fastmail.com>
Date: Mon, 11 Dec 2023 09:17:54 +0000
From: "Jiaxun Yang" <jiaxun.yang@...goat.com>
To: "Yanteng Si" <siyanteng@...ngson.cn>,
 "Krzysztof Kozlowski" <krzysztof.kozlowski@...aro.org>,
 "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
 "Andrew Lunn" <andrew@...n.ch>, "Conor Dooley" <conor@...nel.org>
Cc: "Rob Herring" <robh+dt@...nel.org>,
 "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
 "Conor Dooley" <conor+dt@...nel.org>,
 "Giuseppe Cavallaro" <peppe.cavallaro@...com>,
 "Alexandre Torgue" <alexandre.torgue@...s.st.com>,
 "Jose Abreu" <joabreu@...opsys.com>,
 "David S . Miller" <davem@...emloft.net>,
 "Eric Dumazet" <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>,
 "Paolo Abeni" <pabeni@...hat.com>,
 "Maxime Coquelin" <mcoquelin.stm32@...il.com>, devicetree@...r.kernel.org,
 "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [RFT PATCH 1/2] stmmac: dwmac-loongson: drop useless check for compatible
 fallback

在2023年12月10日十二月 上午6:48，Yanteng Si写道：
> 在 2023/6/17 02:52, Conor Dooley 写道:
>> On Fri, Jun 16, 2023 at 12:31:26PM +0200, Krzysztof Kozlowski wrote:
>>> Device binds to proper PCI ID (LOONGSON, 0x7a03), already listed in DTS,
>>> so checking for some other compatible does not make sense.  It cannot be
>>> bound to unsupported platform.
>>>
>>> Drop useless, incorrect (space in between) and undocumented compatible.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> Might be worth noting that dropping it is required to allow the
>> new loongarch dts stuff to be functional with a sane set of compatibles.
>>
>> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> Thank you Krzysztof for your work. when I am
> adding more devices support to stmmac, I found that your
> two patches seemed to be forgotten.
> Thomas, Jiaxun. Can the two patches get an Acked-by?
> My stmmac patch thread:
> <https://lore.kernel.org/loongarch/cover.1699533745.git 
> .siyanteng@...ngson.cn/T/#md3108d29a5efe71b27f4c5ccf5d0217571bf6586>

Acked-by: Jiaxun Yang <jiaxun.yang@...goat.com>

Better to resend without RFC :-)

Thanks

> Thanks,
> Yanteng
>
>>
>> Cheers,
>> Conor.

-- 
- Jiaxun