netdev - Re: [PATCH net-next v6] netlink: specs: devlink: add some(not all) missing attributes in devlink.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZXcB/6tv/kuX4R91@nanopsycho>
Date: Mon, 11 Dec 2023 13:35:11 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: swarup <swarupkotikalapudi@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH net-next v6] netlink: specs: devlink: add some(not all)
 missing attributes in devlink.yaml

Mon, Dec 11, 2023 at 01:20:13PM CET, swarupkotikalapudi@...il.com wrote:
>esOn Mon, Dec 11, 2023 at 10:46:18AM +0100, Jiri Pirko wrote:
>> Fri, Dec 08, 2023 at 07:25:15PM CET, swarupkotikalapudi@...il.com wrote:
>> >Add some missing(not all) attributes in devlink.yaml.
>> >
>> >Signed-off-by: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@...il.com>
>> >Suggested-by: Jiri Pirko <jiri@...nulli.us>
>> >---
>> >V6:
>> >  - Fix review comments
>> 
>> Would be nice to list what changes you actually did.
>> 
>> Nevertheless, patch looks fine to me.
>> 
>> Reviewed-by: Jiri Pirko <jiri@...dia.com>
>
>Hi Jiri,
>
>Do you mean in the commit message, i should have listed all the changes?

In the changelog (the line I commented), you should try to describe what
exactly did you change from the last version, so the reviewer knows what
to focus on and what to expect.

>Please clarify, if required i update the commit message.

No, next time.


>
>Thanks,
>Swarup