netdev - Re: [PATCH v7 net-next 6/8] net: ethernet: ti: am65-cpsw-qos: Add Frame Preemption MAC Merge support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231211132619.mq5jzyibva7ogrc3@skbuf>
Date: Mon, 11 Dec 2023 15:26:19 +0200
From: Vladimir Oltean <vladimir.oltean@....com>
To: Roger Quadros <rogerq@...nel.org>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, s-vadapalli@...com, r-gunasekaran@...com,
	vigneshr@...com, srk@...com, horms@...nel.org, p-varis@...com,
	netdev@...r.kernel.org
Subject: Re: [PATCH v7 net-next 6/8] net: ethernet: ti: am65-cpsw-qos: Add
 Frame Preemption MAC Merge support

On Mon, Dec 11, 2023 at 02:25:35PM +0200, Roger Quadros wrote:
> The config option mentions only about TAS/EST 802.1Qbv.
> Maybe it needs to be extended to include IET/Frame-preeption 802.1Qbu as well?
> 
> This is the simplest way as the file am65-cpsw-qos.c can be completely omitted if
> TI_AM65_CPSW_TSN is not set.

As long as you need to look no further than in "make menuconfig" to
figure out what you're enabling, it should be fine.

Furthermore, some consistency between the file name (-qos.c) and the
Kconfig option (_TAS/_TSN) would be nice.