[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <67557c83-4318-4557-ac96-858053b5f89b@lunn.ch>
Date: Mon, 11 Dec 2023 15:09:09 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>
Cc: Simon Horman <horms@...nel.org>, davem@...emloft.net,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
thomas.petazzoni@...tlin.com, Jakub Kicinski <kuba@...nel.org>,
Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
Russell King <linux@...linux.org.uk>,
linux-arm-kernel@...ts.infradead.org,
Christophe Leroy <christophe.leroy@...roup.eu>,
Herve Codina <herve.codina@...tlin.com>,
Florian Fainelli <f.fainelli@...il.com>,
Heiner Kallweit <hkallweit1@...il.com>,
Vladimir Oltean <vladimir.oltean@....com>,
Köry Maincent <kory.maincent@...tlin.com>,
Jesse Brandeburg <jesse.brandeburg@...el.com>,
Jonathan Corbet <corbet@....net>,
Marek Behún <kabel@...nel.org>,
Piergiorgio Beruto <piergiorgio.beruto@...il.com>,
Oleksij Rempel <o.rempel@...gutronix.de>,
Nicolò Veronese <nicveronese@...il.com>
Subject: Re: [RFC PATCH net-next v3 01/13] net: phy: Introduce ethernet link
topology representation
> > > @@ -10832,6 +10833,8 @@ struct net_device *alloc_netdev_mqs(int sizeof_priv, const char *name,
> > > #ifdef CONFIG_NET_SCHED
> > > hash_init(dev->qdisc_hash);
> > > #endif
> > > + phy_link_topo_init(&dev->link_topo);
> > > +
> >
> > I don't think this can work unless PHYLIB is compiled as a built-in.
>
> Inded, I need to better clarify and document the dependency with
> PHYLIB.
It is getting harder and harder to make the phylib core a module :-(
How much work does phy_link_topo_init() do? Could it be an inline
function? Are there other dependencies?
Also look at ethtool_phy_ops and e.g. how plca_get_cfg_prepare_data()
uses it.
Andrew
Powered by blists - more mailing lists