[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3b4d8d01-8082-41fb-91f3-5ae5c3ca5bfe@linaro.org>
Date: Mon, 11 Dec 2023 17:01:58 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>, Russell King
<linux@...linux.org.uk>, netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [net-next PATCH 1/2] dt-bindings: Document QCA808x PHYs
On 11/12/2023 13:18, Christian Marangi wrote:
>>> + QCA808X PHYs can have up to 3 LEDs attached.
>>> + All 3 LEDs are disabled by default.
>>> + 2 LEDs have dedicated pins with the 3rd LED having the
>>> + double function of Interrupt LEDs/GPIO or additional LED.
>>> +
>>> + By default this special PIN is set to LED function.
>>> +
>>> +allOf:
>>> + - $ref: ethernet-phy.yaml#
>>> +
>>> +select:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + enum:
>>> + - ethernet-phy-id004d.d101
>>
>> I have impression that this is continuation of some other patchset...
>> Anyway, id004d.d101 is specific to QCA808x?
>>
>
> I used enum assuming eventually more qca808x PHY will come... Yes that
> ID is specific and it's the id of QCA8081. Better to use const?
No, it is fine. I just wanted to be sure that this will not be matched
by other bindings.
Best regards,
Krzysztof
Powered by blists - more mailing lists