netdev - Re: [PATCH net-next v5 2/5] ice: configure FW logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d075fbb9-4cf3-474d-8bf1-af8a6a1109f7@intel.com>
Date: Mon, 11 Dec 2023 09:04:18 -0800
From: Paul M Stillwell Jr <paul.m.stillwell.jr@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Tony Nguyen <anthony.l.nguyen@...el.com>, <davem@...emloft.net>,
	<pabeni@...hat.com>, <edumazet@...gle.com>, <netdev@...r.kernel.org>,
	<jacob.e.keller@...el.com>, <vaishnavi.tipireddy@...el.com>,
	<horms@...nel.org>, <leon@...nel.org>, Pucha Himasekhar Reddy
	<himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net-next v5 2/5] ice: configure FW logging

On 12/11/2023 8:30 AM, Jakub Kicinski wrote:
> On Sat, 9 Dec 2023 16:09:40 -0800 Paul M Stillwell Jr wrote:
>> This brings up the question of whether I should use seq_printf() for all
>> the other _read fucntions. It feels like a lot of extra code to do it
>> for the other _read functions because they output so little info and we
>> control the output so it seems to be overkill to use seq_printf() for
>> those. What do you think?
> 
> My rule of thumb would be to use seq_printf() if you have to allocate
> a buffer on the heap for the output. If you can output directly to user
> space or the output is small enough to fit in an on-stack buffer - no
> need for seq_printf(). But YMMV.

OK, thanks for the feedback!