netdev - Re: [Intel-wired-lan] [PATCH iwl-next v4 0/7] Add PFCP filter support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aeb76f91-ab1d-b951-f895-d618622b137b@intel.com>
Date: Mon, 11 Dec 2023 13:23:20 -0800
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Alexander Lobakin <aleksander.lobakin@...el.com>, Marcin Szycik
	<marcin.szycik@...ux.intel.com>
CC: <jiri@...nulli.us>, <andy@...nel.org>, <wojciech.drewek@...el.com>,
	<netdev@...r.kernel.org>, <idosch@...dia.com>, <jesse.brandeburg@...el.com>,
	<michal.swiatkowski@...ux.intel.com>, <simon.horman@...igine.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <davem@...emloft.net>,
	<intel-wired-lan@...ts.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 0/7] Add PFCP filter support



On 12/11/2023 4:38 AM, Alexander Lobakin wrote:
> From: Tony Nguyen <anthony.l.nguyen@...el.com>
> Date: Fri, 8 Dec 2023 13:34:10 -0800
> 
>>
>>
>> On 12/7/2023 8:49 AM, Marcin Szycik wrote:
>>> Add support for creating PFCP filters in switchdev mode. Add pfcp module
>>> that allows to create a PFCP-type netdev. The netdev then can be
>>> passed to
>>> tc when creating a filter to indicate that PFCP filter should be created.
>>>
>>> To add a PFCP filter, a special netdev must be created and passed to tc
>>> command:
>>>
>>>     ip link add pfcp0 type pfcp
>>>     tc filter add dev eth0 ingress prio 1 flower pfcp_opts \
>>>       1:12ab/ff:fffffffffffffff0 skip_hw action mirred egress redirect \
>>>       dev pfcp0
>>>
>>> Changes in iproute2 [1] are required to use pfcp_opts in tc.
>>>
>>> ICE COMMS package is required as it contains PFCP profiles.
>>>
>>> Part of this patchset modifies IP_TUNNEL_*_OPTs, which were previously
>>> stored in a __be16. All possible values have already been used, making it
>>> impossible to add new ones.
>>>
>>> [1]
>>> https://lore.kernel.org/netdev/20230614091758.11180-1-marcin.szycik@linux.intel.com
>>> ---
>>> This patchset should be applied on top of the "boys" tree [2], as it
>>> depends on recent bitmap changes.
>>
>> Is this for comment only (RFC)? This doesn't seem to apply to iwl-next
>> and if this based on, and has dependencies from, another tree, I can't
>> apply them here.
> 
> It's not an RFC.
> The series contains generic code changes and must go directly through
> net-next. 

Should this be marked for 'net-next' rather than 'iwl-next' then?

Thanks,
Tony

> The dependency on the bitmap tree was discussed with Jakub and
> Yury and we agreed that the netdev guys will pull it before applying
> this one.
> 
> Thanks,
> Olek