[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZXeOef/60Crhrm2Y@yury-ThinkPad>
Date: Mon, 11 Dec 2023 14:34:33 -0800
From: Yury Norov <yury.norov@...il.com>
To: Alexandra Winter <wintera@...ux.ibm.com>
Cc: linux-kernel@...r.kernel.org, Karsten Graul <kgraul@...ux.ibm.com>,
Wenjia Zhang <wenjia@...ux.ibm.com>,
Jan Karcher <jaka@...ux.ibm.com>,
"D. Wythe" <alibuda@...ux.alibaba.com>,
Tony Lu <tonylu@...ux.alibaba.com>,
Wen Gu <guwen@...ux.alibaba.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
linux-s390@...r.kernel.org, netdev@...r.kernel.org,
Jan Kara <jack@...e.cz>,
Mirsad Todorovac <mirsad.todorovac@....unizg.hr>,
Matthew Wilcox <willy@...radead.org>,
Rasmus Villemoes <linux@...musvillemoes.dk>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Maxim Kuvyrkov <maxim.kuvyrkov@...aro.org>,
Alexey Klimov <klimov.linux@...il.com>,
Bart Van Assche <bvanassche@....org>,
Sergey Shtylyov <s.shtylyov@....ru>
Subject: Re: [PATCH v2 31/35] net: smc: use find_and_set_bit() in
smc_wr_tx_get_free_slot_index()
On Mon, Dec 04, 2023 at 10:40:20AM +0100, Alexandra Winter wrote:
>
>
> On 03.12.23 20:33, Yury Norov wrote:
> > The function opencodes find_and_set_bit() with a for_each() loop. Use
> > it, and make the whole function a simple almost one-liner.
> >
> > While here, drop explicit initialization of *idx, because it's already
> > initialized by the caller in case of ENOLINK, or set properly with
> > ->wr_tx_mask, if nothing is found, in case of EBUSY.
> >
> > CC: Tony Lu <tonylu@...ux.alibaba.com>
> > CC: Alexandra Winter <wintera@...ux.ibm.com>
> > Signed-off-by: Yury Norov <yury.norov@...il.com>
> > ---
>
> Reviewed-by: Alexandra Winter <wintera@...ux.ibm.com>
>
>
> Thanks a lot for the great helper function!
> I guess the top-level maintainers will figure out, how this series best finds its way upstream.
Thanks, Alexandra. :)
People in this thread say just pick their subsystem patch together
with #1. So, I'm going to send v3 with some minor tweaks, and if
everything is OK, will pull all this in my bitmap-for-next branch.
Thanks,
Yury
Powered by blists - more mailing lists