netdev - Re: [PATCH v3 net-next 3/8] net: dsa: mv88e6xxx: Fix mv88e6352_serdes_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c05c48c-eb86-429b-8496-a06b37f851a2@gmail.com>
Date: Mon, 11 Dec 2023 14:55:40 -0800
From: Florian Fainelli <f.fainelli@...il.com>
To: Tobias Waldekranz <tobias@...dekranz.com>, davem@...emloft.net,
 kuba@...nel.org
Cc: andrew@...n.ch, olteanv@...il.com, netdev@...r.kernel.org,
 Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH v3 net-next 3/8] net: dsa: mv88e6xxx: Fix
 mv88e6352_serdes_get_stats error path

On 12/11/23 14:33, Tobias Waldekranz wrote:
> mv88e6xxx_get_stats, which collects stats from various sources,
> expects all callees to return the number of stats read. If an error
> occurs, 0 should be returned.
> 
> Prevent future mishaps of this kind by updating the return type to
> reflect this contract.
> 
> Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>
> Signed-off-by: Tobias Waldekranz <tobias@...dekranz.com>

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian