netdev - Re: [PATCH net-next] net: stmmac: xgmac3+: add FPE handshaking support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231211145944.0be51404@kernel.org>
Date: Mon, 11 Dec 2023 14:59:44 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Serge Semin <fancer.lancer@...il.com>
Cc: Jianheng Zhang <Jianheng.Zhang@...opsys.com>, Alexandre Torgue
 <alexandre.torgue@...s.st.com>, Jose Abreu <Jose.Abreu@...opsys.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin
 <mcoquelin.stm32@...il.com>, "open list:STMMAC ETHERNET DRIVER"
 <netdev@...r.kernel.org>, "moderated list:ARM/STM32 ARCHITECTURE"
 <linux-stm32@...md-mailman.stormreply.com>, "moderated list:ARM/STM32
 ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>, open list
 <linux-kernel@...r.kernel.org>, James Li <James.Li1@...opsys.com>, Martin
 McKenny <Martin.McKenny@...opsys.com>
Subject: Re: [PATCH net-next] net: stmmac: xgmac3+: add FPE handshaking
 support

On Mon, 11 Dec 2023 14:14:00 +0300 Serge Semin wrote:
> Although in this case AFAICS the implementation is simpler and the
> only difference is in the CSR offset and the frame preemption residue
> queue ID setting. All of that can be easily solved in the same way as
> it was done for EST (see the link above).
> 
> Jakub, what do you think?

Yup, less code duplication would be great. Highest prio, tho, is to
focus on Vladimir's comment around this driver seemingly implementing
FPE but not using the common ethtool APIs to configure it, yet :(