netdev - Re: [PATCH 5/8] dpaa2-switch: do not clear any interrupts automatically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 12 Dec 2023 14:17:37 +0200
From: Ioana Ciornei <ioana.ciornei@....com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, 
	netdev@...r.kernel.org
Subject: Re: [PATCH 5/8] dpaa2-switch: do not clear any interrupts
 automatically

On Tue, Dec 05, 2023 at 08:02:32PM -0800, Jakub Kicinski wrote:
> On Mon,  4 Dec 2023 18:35:25 +0200 Ioana Ciornei wrote:
> > The dpsw_get_irq_status() can clear interrupts automatically based on
> > the value stored in the 'status' variable passed to it. We don't want
> > that to happen because we could get into a situation when we are
> > clearing more interrupts that we actually handled.
> > 
> > Just resort to manually clearing interrupts after we received them using
> > the dpsw_clear_irq_status().
> 
> Currently it can't cause any issues?
> We won't get into an IRQ storm if some unexpected IRQ fires?

We don't get into an IRQ storm because we can configure which event
sources can raise the IRQ. This means that the driver can ask only for
the events which are handled.