netdev - Re: [PATCH net-next v2 2/2] selftests: fib_tests: Add tests for toggling between w/ and w/o expires.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83a83ca3-3481-4e2d-a952-37437fca1800@gmail.com>
Date: Mon, 11 Dec 2023 18:40:43 -0800
From: Kui-Feng Lee <sinquersw@...il.com>
To: Hangbin Liu <liuhangbin@...il.com>, thinker.li@...il.com
Cc: netdev@...r.kernel.org, martin.lau@...ux.dev, kernel-team@...a.com,
 davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, dsahern@...nel.org,
 edumazet@...gle.com, kuifeng@...a.com
Subject: Re: [PATCH net-next v2 2/2] selftests: fib_tests: Add tests for
 toggling between w/ and w/o expires.



On 12/11/23 18:20, Hangbin Liu wrote:
> On Fri, Dec 08, 2023 at 11:45:23AM -0800, thinker.li@...il.com wrote:
>> From: Kui-Feng Lee <thinker.li@...il.com>
>>
>> Make sure that toggling routes between w/ expires and w/o expires works
>> properly with GC list.
>>
>> When a route with expires is replaced by a permanent route, the entry
>> should be removed from the gc list. When a permanent routes is replaced by
>> a temporary route, the new entry should be added to the gc list. The new
>> tests check if these basic operators work properly.
>>
>> Signed-off-by: Kui-Feng Lee <thinker.li@...il.com>
>> ---
>>   tools/testing/selftests/net/fib_tests.sh | 69 +++++++++++++++++++++++-
>>   1 file changed, 67 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/testing/selftests/net/fib_tests.sh b/tools/testing/selftests/net/fib_tests.sh
>> index 66d0db7a2614..a8b4628fd7d2 100755
>> --- a/tools/testing/selftests/net/fib_tests.sh
>> +++ b/tools/testing/selftests/net/fib_tests.sh
>> @@ -806,10 +806,75 @@ fib6_gc_test()
>>   	    ret=0
>>   	fi
>>   
>> -	set +e
>> -
>>   	log_test $ret 0 "ipv6 route garbage collection"
>>   
>> +	# Delete permanent routes
>> +	for i in $(seq 1 5000); do
>> +	    $IP -6 route del 2001:30::$i \
>> +		via 2001:10::2 dev dummy_10
>> +	done
>> +
>> +	# Permanent routes
>> +	for i in $(seq 1 100); do
>> +	    # Expire route after $EXPIRE seconds
>> +	    $IP -6 route add 2001:20::$i \
>> +		via 2001:10::2 dev dummy_10
>> +	done
>> +	# Replace with temporary routes
>> +	for i in $(seq 1 100); do
>> +	    # Expire route after $EXPIRE seconds
>> +	    $IP -6 route replace 2001:20::$i \
>> +		via 2001:10::2 dev dummy_10 expires $EXPIRE
>> +	done
>> +	N_EXP_SLEEP=$($IP -6 route list |grep expires|wc -l)
>> +	if [ $N_EXP_SLEEP -ne 100 ]; then
>> +	    echo "FAIL: expected 100 routes with expires, got $N_EXP_SLEEP"
> 
> Hi,
> 
> Here the test failed, but ret is not updated.
> 
>> +	fi
>> +	sleep $(($EXPIRE * 2 + 1))
>> +	N_EXP_SLEEP=$($IP -6 route list |grep expires|wc -l)
>> +	if [ $N_EXP_SLEEP -ne 0 ]; then
>> +	    echo "FAIL: expected 0 routes with expires," \
>> +		 "got $N_EXP_SLEEP"
>> +	    ret=1
> 
> Here the ret is updated.
> 
>> +	else
>> +	    ret=0
>> +	fi
>> +
>> +	log_test $ret 0 "ipv6 route garbage collection (replace with expires)"
>> +
>> +	PERM_BASE=$($IP -6 route list |grep -v expires|wc -l)
>> +	# Temporary routes
>> +	for i in $(seq 1 100); do
>> +	    # Expire route after $EXPIRE seconds
>> +	    $IP -6 route add 2001:20::$i \
>> +		via 2001:10::2 dev dummy_10 expires $EXPIRE
>> +	done
>> +	# Replace with permanent routes
>> +	for i in $(seq 1 100); do
>> +	    # Expire route after $EXPIRE seconds
>> +	    $IP -6 route replace 2001:20::$i \
>> +		via 2001:10::2 dev dummy_10
>> +	done
>> +	N_EXP_SLEEP=$($IP -6 route list |grep expires|wc -l)
>> +	if [ $N_EXP_SLEEP -ne 0 ]; then
>> +	    echo "FAIL: expected 0 routes with expires," \
>> +		 "got $N_EXP_SLEEP"
> 
> Same here.
> 
> Thanks
> Hangbin
>> +	fi
>> +	sleep $(($EXPIRE * 2 + 1))
>> +	N_EXP_PERM=$($IP -6 route list |grep -v expires|wc -l)
>> +	N_EXP_PERM=$(($N_EXP_PERM - $PERM_BASE))
>> +	if [ $N_EXP_PERM -ne 100 ]; then
>> +	    echo "FAIL: expected 100 permanent routes," \
>> +		 "got $N_EXP_PERM"
>> +	    ret=1
>> +	else
>> +	    ret=0
>> +	fi
>> +
>> +	log_test $ret 0 "ipv6 route garbage collection (replace with permanent)"
>> +
>> +	set +e
>> +
>>   	cleanup &> /dev/null
>>   }
>>   
>> -- 
>> 2.34.1
>>
Got it! Thanks!