netdev - Re: [PATCH] wifi: iwlwifi: fw/dbg: fix all kernel-doc warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 12 Dec 2023 19:24:52 +0000
From: Simon Horman <horms@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: netdev@...r.kernel.org, kernel test robot <lkp@...el.com>,
	Gregory Greenman <gregory.greenman@...el.com>,
	Miri Korenblit <miriam.rachel.korenblit@...el.com>,
	linux-wireless@...r.kernel.org, Kalle Valo <kvalo@...nel.org>,
	Johannes Berg <johannes@...solutions.net>
Subject: Re: [PATCH] wifi: iwlwifi: fw/dbg: fix all kernel-doc warnings

On Fri, Dec 08, 2023 at 02:09:45PM -0800, Randy Dunlap wrote:
> kernel test robot reports:
> drivers/net/wireless/intel/iwlwifi/fw/dbg.c:86: warning: Excess struct/union/enum/typedef member 'trans_len' description in 'iwl_fw_dump_ptrs'
> 
> scripts/kernel-doc no longer emits the warning that is reported by
> the 0-day kernel test robot, but the reported struct does contain the
> Excess line, so remove that line as well as fix other kernel-doc
> warnings in this source file:
> 
> dbg.c:1732: warning: contents before sections
> dbg.c:1736: warning: No description found for return value of 'mask_apply_and_normalize'
> dbg.c:2202: warning: missing initial short description on line:
>  * iwl_dump_ini_mem
> dbg.c:2207: warning: contents before sections
> dbg.c:2215: warning: No description found for return value of 'iwl_dump_ini_mem'
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202311250305.tf8Cus1Y-lkp@intel.com/
> Closes: https://lore.kernel.org/oe-kbuild-all/202312060810.QT9zourt-lkp@intel.com/
> Cc: Gregory Greenman <gregory.greenman@...el.com>
> Cc: Miri Korenblit <miriam.rachel.korenblit@...el.com>
> Cc: linux-wireless@...r.kernel.org
> Cc: Kalle Valo <kvalo@...nel.org>
> Cc: Johannes Berg <johannes@...solutions.net>

Thanks Randy,

I'm unable to reproduce the "other warnings".
But these changes do look good to me.

Reviewed-by: Simon Horman <horms@...nel.org>

...