netdev - Re: [PATCH] net, xdp: correct grammar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78c0072a-c084-4588-b973-ad4f80047914@kernel.org>
Date: Wed, 13 Dec 2023 09:39:08 +0100
From: Jesper Dangaard Brouer <hawk@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>, netdev@...r.kernel.org
Cc: Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>,
 "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 John Fastabend <john.fastabend@...il.com>, bpf@...r.kernel.org
Subject: Re: [PATCH] net, xdp: correct grammar



On 13/12/2023 05.37, Randy Dunlap wrote:
> Use the correct verb form in 2 places.
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Alexei Starovoitov <ast@...nel.org>
> Cc: Daniel Borkmann <daniel@...earbox.net>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Jesper Dangaard Brouer <hawk@...nel.org>
> Cc: John Fastabend <john.fastabend@...il.com>
> Cc: bpf@...r.kernel.org
> ---
>   include/net/xdp.h |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 

Acked-by: Jesper Dangaard Brouer <hawk@...nel.org>

> diff -- a/include/net/xdp.h b/include/net/xdp.h
> --- a/include/net/xdp.h
> +++ b/include/net/xdp.h
> @@ -16,7 +16,7 @@
>    *
>    * The XDP RX-queue info (xdp_rxq_info) is associated with the driver
>    * level RX-ring queues.  It is information that is specific to how
> - * the driver have configured a given RX-ring queue.
> + * the driver has configured a given RX-ring queue.
>    *
>    * Each xdp_buff frame received in the driver carries a (pointer)
>    * reference to this xdp_rxq_info structure.  This provides the XDP
> @@ -32,7 +32,7 @@
>    * The struct is not directly tied to the XDP prog.  A new XDP prog
>    * can be attached as long as it doesn't change the underlying
>    * RX-ring.  If the RX-ring does change significantly, the NIC driver
> - * naturally need to stop the RX-ring before purging and reallocating
> + * naturally needs to stop the RX-ring before purging and reallocating
>    * memory.  In that process the driver MUST call unregister (which
>    * also applies for driver shutdown and unload).  The register API is
>    * also mandatory during RX-ring setup.