netdev - Re: [PATCH iwl-next v4 1/2] ixgbe: Refactor overtemp event handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce4a2471-cdd4-5ecf-ef6e-a91f8cb3fe5d@intel.com>
Date: Wed, 13 Dec 2023 10:20:06 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Jedrzej Jagielski <jedrzej.jagielski@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>
CC: <anthony.l.nguyen@...el.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH iwl-next v4 1/2] ixgbe: Refactor overtemp event handling

On 12/12/23 11:46, Jedrzej Jagielski wrote:
> Currently ixgbe driver is notified of overheating events
> via internal IXGBE_ERR_OVERTEMP error code.
> 
> Change the approach for handle_lasi() to use freshly introduced
> is_overtemp function parameter which set when such event occurs.
> Change check_overtemp() to bool and return true if overtemp
> event occurs.
> 
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
> ---
> v2: change aproach to use additional function parameter to notify when overheat
> v4: change check_overtemp to bool
> 
> https://lore.kernel.org/netdev/20231208090055.303507-1-jedrzej.jagielski@intel.com/T/
> ---
>   drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 19 ++++----
>   drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c  | 26 ++++++-----
>   drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h  |  2 +-
>   drivers/net/ethernet/intel/ixgbe/ixgbe_type.h |  4 +-
>   drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 45 +++++++++++--------
>   5 files changed, 54 insertions(+), 42 deletions(-)

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>