netdev - Re: [PATCH] page_pool: fix typos and punctuation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 13 Dec 2023 12:39:40 +0200
From: Ilias Apalodimas <ilias.apalodimas@...aro.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: netdev@...r.kernel.org, Jesper Dangaard Brouer <hawk@...nel.org>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH] page_pool: fix typos and punctuation

Hi Randy,

Thanks for cleaning this up

On Wed, 13 Dec 2023 at 06:36, Randy Dunlap <rdunlap@...radead.org> wrote:
>
> Correct spelling (s/and/any) and a run-on sentence.
> Spell out "multi".
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Jesper Dangaard Brouer <hawk@...nel.org>
> Cc: Ilias Apalodimas <ilias.apalodimas@...aro.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> ---
>  include/net/page_pool/helpers.h |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff -- a/include/net/page_pool/helpers.h b/include/net/page_pool/helpers.h
> --- a/include/net/page_pool/helpers.h
> +++ b/include/net/page_pool/helpers.h
> @@ -11,7 +11,7 @@
>   * The page_pool allocator is optimized for recycling page or page fragment used
>   * by skb packet and xdp frame.
>   *
> - * Basic use involves replacing and alloc_pages() calls with page_pool_alloc(),
> + * Basic use involves replacing any alloc_pages() calls with page_pool_alloc(),
>   * which allocate memory with or without page splitting depending on the
>   * requested memory size.
>   *
> @@ -37,15 +37,15 @@
>   * attach the page_pool object to a page_pool-aware object like skbs marked with
>   * skb_mark_for_recycle().
>   *
> - * page_pool_put_page() may be called multi times on the same page if a page is
> - * split into multi fragments. For the last fragment, it will either recycle the
> - * page, or in case of page->_refcount > 1, it will release the DMA mapping and
> - * in-flight state accounting.
> + * page_pool_put_page() may be called multiple times on the same page if a page
> + * is split into multiple fragments. For the last fragment, it will either
> + * recycle the page, or in case of page->_refcount > 1, it will release the DMA
> + * mapping and in-flight state accounting.
>   *
>   * dma_sync_single_range_for_device() is only called for the last fragment when
>   * page_pool is created with PP_FLAG_DMA_SYNC_DEV flag, so it depends on the
>   * last freed fragment to do the sync_for_device operation for all fragments in
> - * the same page when a page is split, the API user must setup pool->p.max_len
> + * the same page when a page is split. The API user must setup pool->p.max_len
>   * and pool->p.offset correctly and ensure that page_pool_put_page() is called
>   * with dma_sync_size being -1 for fragment API.
>   */

Acked-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>