[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZXnRlERUGhwxKJxi@shell.armlinux.org.uk>
Date: Wed, 13 Dec 2023 15:45:24 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Florian Fainelli <florian.fainelli@...adcom.com>,
Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Vladimir Oltean <olteanv@...il.com>,
David Epping <david.epping@...singlinkelectronics.com>,
Harini Katakam <harini.katakam@....com>,
Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [net-next PATCH v6 1/3] net: phy: extend PHY package API to
support multiple global address
On Wed, Dec 13, 2023 at 11:57:28AM +0100, Christian Marangi wrote:
> -static inline int phy_package_read(struct phy_device *phydev, u32 regnum)
> +static inline int phy_package_read(struct phy_device *phydev,
> + unsigned int addr_offset, u32 regnum)
> {
> struct phy_package_shared *shared = phydev->shared;
> + int addr = shared->base_addr + addr_offset;
>
> - if (!shared)
> + if (addr >= PHY_MAX_ADDR)
> return -EIO;
If we're going to check the address, I think we should check it
properly, which means also checking whether it's become negative.
Alternatively, we could consider making "addr" and "base_addr"
unsigned types, since they should never be negative. However,
that probably should be done as a separate patch before this one.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists