[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZXkNf9vvtzR7oqoE@TONYMAC-ALIBABA.local>
Date: Wed, 13 Dec 2023 09:48:47 +0800
From: Tony Lu <tonylu@...ux.alibaba.com>
To: Ahelenia Ziemia'nska <nabijaczleweli@...ijaczleweli.xyz>
Cc: Karsten Graul <kgraul@...ux.ibm.com>,
Wenjia Zhang <wenjia@...ux.ibm.com>,
Jan Karcher <jaka@...ux.ibm.com>,
"D. Wythe" <alibuda@...ux.alibaba.com>,
Wen Gu <guwen@...ux.alibaba.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
linux-s390@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND 06/11] net/smc: smc_splice_read: always request
MSG_DONTWAIT
Please add correct tag, for this patch, IIUC, it should be a fix, and
you need add [PATCH net].
On Tue, Dec 12, 2023 at 11:12:47AM +0100, Ahelenia Ziemia'nska wrote:
> Otherwise we risk sleeping with the pipe locked for indeterminate
> lengths of time.
>
> Link: https://lore.kernel.org/linux-fsdevel/qk6hjuam54khlaikf2ssom6custxf5is2ekkaequf4hvode3ls@zgf7j5j4ubvw/t/#u
Fixes line is needed.
> Signed-off-by: Ahelenia Ziemia'nska <nabijaczleweli@...ijaczleweli.xyz>
> ---
> net/smc/af_smc.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
> index bacdd971615e..89473305f629 100644
> --- a/net/smc/af_smc.c
> +++ b/net/smc/af_smc.c
> @@ -3243,12 +3243,8 @@ static ssize_t smc_splice_read(struct socket *sock, loff_t *ppos,
> rc = -ESPIPE;
> goto out;
> }
> - if (flags & SPLICE_F_NONBLOCK)
> - flags = MSG_DONTWAIT;
> - else
> - flags = 0;
> SMC_STAT_INC(smc, splice_cnt);
> - rc = smc_rx_recvmsg(smc, NULL, pipe, len, flags);
> + rc = smc_rx_recvmsg(smc, NULL, pipe, len, MSG_DONTWAIT);
> }
> out:
> release_sock(sk);
> --
> 2.39.2
Powered by blists - more mailing lists