netdev - Re: [PATCH iproute2-next] ss: Add support for dumping TCP bound-inactive sockets.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8368c084-6092-455e-8011-9d5bd4f2699d@gmail.com>
Date: Wed, 13 Dec 2023 09:16:49 -0800
From: David Ahern <dsahern@...il.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>, gnault@...hat.com
Cc: edumazet@...gle.com, mkubecek@...e.cz, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next] ss: Add support for dumping TCP
 bound-inactive sockets.

On 12/11/23 7:19 AM, Kuniyuki Iwashima wrote:
>> diff --git a/misc/ss.c b/misc/ss.c
>> index 16ffb6c8..19adc1b7 100644
>> --- a/misc/ss.c
>> +++ b/misc/ss.c
>> @@ -210,6 +210,8 @@ enum {
>>  	SS_LAST_ACK,
>>  	SS_LISTEN,
>>  	SS_CLOSING,
>> +	SS_NEW_SYN_RECV,
> 
> I think this is bit confusing as TCP_NEW_SYN_RECV is usually
> invisible from user.
> 
> TCP_NEW_SYN_RECV was originally split from TCP_SYN_RECV for a
> non-{TFO,cross-SYN} request.
> 
> So, both get_openreq4() (/proc/net/tcp) and inet_req_diag_fill()
> (inet_diag) maps TCP_NEW_SYN_RECV to TCP_SYN_RECV.
> 
> 
>> +	SS_BOUND_INACTIVE,
> 
> I prefer explicitly assigning a number to SS_BOUND_INACTIVE.
> 

this is internal to the ss command; explicit value is not relevant.