netdev - Re: [PATCH] tcp: disable tcp_autocorking for socket when TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+0gbPkw+4GdcBfi6TWkypTtf1gBJyBSoH+=q8pdS_ngg@mail.gmail.com>
Date: Wed, 13 Dec 2023 20:29:53 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Paolo Abeni <pabeni@...hat.com>, Salvatore Dipietro <dipiets@...zon.com>, davem@...emloft.net, 
	dsahern@...nel.org, netdev@...r.kernel.org, blakgeof@...zon.com, 
	alisaidi@...zon.com, benh@...zon.com, dipietro.salvatore@...il.com
Subject: Re: [PATCH] tcp: disable tcp_autocorking for socket when TCP_NODELAY
 flag is set

On Wed, Dec 13, 2023 at 8:00 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 13 Dec 2023 15:10:00 +0100 Eric Dumazet wrote:
> > > It looks like the above disables autocorking even after the userspace
> > > sets TCP_CORK. Am I reading it correctly?Sal Is that expected?
> >
> > Yes, it seems the patch went too far.
>
> Reverted to avoid it getting to Linus in the meantime, FWIW.

Thanks Jakub.