[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202312131208.HLapuT6A-lkp@intel.com>
Date: Wed, 13 Dec 2023 12:59:59 +0800
From: kernel test robot <lkp@...el.com>
To: Christian Marangi <ansuelsmth@...il.com>,
Florian Fainelli <florian.fainelli@...adcom.com>,
Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Vladimir Oltean <olteanv@...il.com>,
David Epping <david.epping@...singlinkelectronics.com>,
"Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
Harini Katakam <harini.katakam@....com>,
linux-kernel@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
netdev@...r.kernel.org
Subject: Re: [net-next PATCH v5 3/3] net: phy: add support for PHY package
MMD read/write
Hi Christian,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Christian-Marangi/net-phy-restructure-__phy_write-read_mmd-to-helper-and-phydev-user/20231212-203921
base: net-next/main
patch link: https://lore.kernel.org/r/20231212123743.29829-3-ansuelsmth%40gmail.com
patch subject: [net-next PATCH v5 3/3] net: phy: add support for PHY package MMD read/write
config: arm-defconfig (https://download.01.org/0day-ci/archive/20231213/202312131208.HLapuT6A-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231213/202312131208.HLapuT6A-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312131208.HLapuT6A-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/phy/phy-core.c:777: warning: expecting prototype for __phy_package_write_mmd(). Prototype was for phy_package_write_mmd() instead
vim +777 drivers/net/phy/phy-core.c
757
758 /**
759 * __phy_package_write_mmd - write MMD reg relative to PHY package base addr
760 * @phydev: The phy_device struct
761 * @addr_offset: The offset to be added to PHY package base_addr
762 * @devad: The MMD to write to
763 * @regnum: The register on the MMD to write
764 * @val: value to write to @regnum
765 *
766 * Convenience helper for writing a register of an MMD on a given PHY
767 * using the PHY package base address. The base address is added to
768 * the addr_offset value.
769 *
770 * Same calling rules as for phy_write();
771 *
772 * NOTE: It's assumed that the entire PHY package is either C22 or C45.
773 */
774 int phy_package_write_mmd(struct phy_device *phydev,
775 unsigned int addr_offset, int devad,
776 u32 regnum, u16 val)
> 777 {
778 struct phy_package_shared *shared = phydev->shared;
779 int addr = shared->base_addr + addr_offset;
780 int ret;
781
782 if (addr >= PHY_MAX_ADDR)
783 return -EIO;
784
785 if (regnum > (u16)~0 || devad > 32)
786 return -EINVAL;
787
788 phy_lock_mdio_bus(phydev);
789 ret = mmd_phy_write(phydev->mdio.bus, addr, phydev->is_c45, devad,
790 regnum, val);
791 phy_unlock_mdio_bus(phydev);
792
793 return ret;
794 }
795 EXPORT_SYMBOL(phy_package_write_mmd);
796
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists