[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAC_iWj+xvjkD27z6xRD2yX30csjaj=yyFFG-1ZoeB4-k2g_0Yw@mail.gmail.com>
Date: Thu, 14 Dec 2023 08:11:49 +0200
From: Ilias Apalodimas <ilias.apalodimas@...aro.org>
To: Liang Chen <liangchen.linux@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, hawk@...nel.org, linyunsheng@...wei.com,
netdev@...r.kernel.org, linux-mm@...ck.org, jasowang@...hat.com,
almasrymina@...gle.com, Mina Almasry <almarsymina@...gle.com>
Subject: Re: [PATCH net-next v10 2/4] page_pool: halve BIAS_MAX for multiple
user references of a fragment
On Thu, 14 Dec 2023 at 06:30, Liang Chen <liangchen.linux@...il.com> wrote:
>
> Up to now, we were only subtracting from the number of used page fragments
> to figure out when a page could be freed or recycled. A following patch
> introduces support for multiple users referencing the same fragment. So
> reduce the initial page fragments value to half to avoid overflowing.
>
> Signed-off-by: Liang Chen <liangchen.linux@...il.com>
> Reviewed-by: Yunsheng Lin <linyunsheng@...wei.com>
> Reviewed-by: Mina Almasry <almarsymina@...gle.com>
> ---
> net/core/page_pool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/page_pool.c b/net/core/page_pool.c
> index 106220b1f89c..436f7ffea7b4 100644
> --- a/net/core/page_pool.c
> +++ b/net/core/page_pool.c
> @@ -26,7 +26,7 @@
> #define DEFER_TIME (msecs_to_jiffies(1000))
> #define DEFER_WARN_INTERVAL (60 * HZ)
>
> -#define BIAS_MAX LONG_MAX
> +#define BIAS_MAX (LONG_MAX >> 1)
>
> #ifdef CONFIG_PAGE_POOL_STATS
> /* alloc_stat_inc is intended to be used in softirq context */
> --
> 2.31.1
>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>
Powered by blists - more mailing lists