netdev - Re: [PATCH iwl-next v2 14/15] ice: cleanup inconsistent code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a163d97-2989-e5f7-e6ba-6dd346ab4236@intel.com>
Date: Thu, 14 Dec 2023 08:16:38 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Jesse Brandeburg <jesse.brandeburg@...el.com>, Kalesh Anakkur Purayil
	<kalesh-anakkur.purayil@...adcom.com>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
	<aleksander.lobakin@...el.com>, <horms@...nel.org>,
	<marcin.szycik@...ux.intel.com>
Subject: Re: [PATCH iwl-next v2 14/15] ice: cleanup inconsistent code

On 12/13/23 19:27, Jesse Brandeburg wrote:
> Please don't use HTML email, your reply was likely dropped by most lists
> that filter HTML.
> 
> On 12/12/2023 8:06 PM, Kalesh Anakkur Purayil wrote:
>>      -       change_type = FIELD_GET(ICE_AQ_LLDP_MIB_TYPE_M,  mib->type);
>>      +       change_type = FIELD_GET(ICE_AQ_LLDP_MIB_TYPE_M, mib->type);
>>
>> [Kalesh]: I did not get what exactly changed here? Is that you just
>> removed one extra space before mib->type?
> 
> Yes, there was a whitespace change missed in the GET series. I had
> caught it only here. If you feel I need to I can resend to add a comment
> to the commit message that this was added here.
> 
> 

I guess that NOT sending next revision is our only chance to fix this
particular white space error ;)