netdev - Re: [PATCH iwl-next v4 2/2] ixgbe: Refactor returning internal error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231214095642.GK5817@kernel.org>
Date: Thu, 14 Dec 2023 09:56:42 +0000
From: Simon Horman <horms@...nel.org>
To: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, anthony.l.nguyen@...el.com,
	netdev@...r.kernel.org, Jacob Keller <jacob.e.keller@...el.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>
Subject: Re: [PATCH iwl-next v4 2/2] ixgbe: Refactor returning internal error
 codes

On Tue, Dec 12, 2023 at 11:46:42AM +0100, Jedrzej Jagielski wrote:
> Change returning codes to the kernel ones instead of
> the internal ones for the entire ixgbe driver.
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
> ---
> v3: do not use ENOSYS; rebase
> ---
>  .../net/ethernet/intel/ixgbe/ixgbe_82598.c    |  36 ++---
>  .../net/ethernet/intel/ixgbe/ixgbe_82599.c    |  61 ++++----
>  .../net/ethernet/intel/ixgbe/ixgbe_common.c   | 145 ++++++++----------
>  .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c  |   2 +-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |  26 ++--
>  drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.c  |  34 ++--
>  drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h  |   1 -
>  drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c  |  84 +++++-----
>  .../net/ethernet/intel/ixgbe/ixgbe_sriov.c    |   2 +-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_type.h |  39 -----
>  drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c |  44 +++---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 109 ++++++-------
>  12 files changed, 266 insertions(+), 317 deletions(-)

Thanks Jedrzej,

this is a nice cleanup.

Reviewed-by: Simon Horman <horms@...nel.org>