netdev - RE: [PATCH net-next v14 09/13] rtase: Implement pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05bd9b22872348c6a931408e7b58106a@realtek.com>
Date: Thu, 14 Dec 2023 12:48:45 +0000
From: JustinLai0215 <justinlai0215@...ltek.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "andrew@...n.ch"
	<andrew@...n.ch>, Ping-Ke Shih <pkshih@...ltek.com>,
        Larry Chiu
	<larry.chiu@...ltek.com>
Subject: RE: [PATCH net-next v14 09/13] rtase: Implement pci_driver suspend and resume function

> 
> On Fri, 8 Dec 2023 17:47:29 +0800 Justin Lai wrote:
> > +static int rtase_suspend(struct device *device) {
> > +     struct net_device *dev = dev_get_drvdata(device);
> > +
> > +     if (netif_running(dev)) {
> > +             netif_stop_queue(dev);
> > +             netif_device_detach(dev);
> 
> detach stops the queue, you don't have to call both

Thanks for the reminder, I will modify it.
> 
> > +             rtase_hw_reset(dev);