[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231215080104.GV5817@kernel.org>
Date: Fri, 15 Dec 2023 08:01:04 +0000
From: Simon Horman <horms@...nel.org>
To: Jijie Shao <shaojijie@...wei.com>
Cc: yisen.zhuang@...wei.com, salil.mehta@...wei.com, davem@...emloft.net,
edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
shenjian15@...wei.com, wangjie125@...wei.com,
liuyonglong@...wei.com, lanhao@...wei.com, wangpeiyang1@...wei.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 net-next 2/3] net: hns3: dump more reg info based on
ras mod
On Thu, Dec 14, 2023 at 10:11:34PM +0800, Jijie Shao wrote:
> From: Peiyang Wang <wangpeiyang1@...wei.com>
>
> Dump more reg info base on ras mod before reset, which is useful to
> analyze the ras error.
>
> Signed-off-by: Peiyang Wang <wangpeiyang1@...wei.com>
> Signed-off-by: Jijie Shao <shaojijie@...wei.com>
...
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.h b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.h
> index 68b738affa66..45a783a50643 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.h
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.h
> @@ -5,6 +5,7 @@
> #define __HCLGE_ERR_H
>
> #include "hclge_main.h"
> +#include "hclge_debugfs.h"
Hi Jijie Shao and Peiyang Wang,
hclge_debugfs.h defines a number of constants, such as hclge_dbg_tqp_reg.
With the above include added, these constants are now also defined
in files that include hclge_err.h. Which leads to them
being defined but unused in hclge_main.c.
At a glance, it seems that these constants are only used in hclge_debugfs.c.
Perhaps they could simply be moved there?
Flagged by gcc-13 W=1 allmodconfig builds.
> #include "hnae3.h"
>
> #define HCLGE_MPF_RAS_INT_MIN_BD_NUM 10
...
Powered by blists - more mailing lists