[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <777c33d6-49a6-47b5-8cdd-5e27c919c53b@linaro.org>
Date: Fri, 15 Dec 2023 09:47:15 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Tobias Waldekranz <tobias@...dekranz.com>, davem@...emloft.net,
kuba@...nel.org
Cc: linux@...linux.org.uk, kabel@...nel.org, andrew@...n.ch,
hkallweit1@...il.com, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, netdev@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH net-next 4/4] dt-bindings: net: marvell10g: Document LED
polarity
On 14/12/2023 21:14, Tobias Waldekranz wrote:
> Hardware supports multiple ways of driving attached LEDs, but this is
> not configurable via any sample-at-reset pins - rather it must be set
> via software.
>
> Signed-off-by: Tobias Waldekranz <tobias@...dekranz.com>
> ---
> .../bindings/net/marvell,marvell10g.yaml | 60 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 61 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/marvell,marvell10g.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/marvell,marvell10g.yaml b/Documentation/devicetree/bindings/net/marvell,marvell10g.yaml
> new file mode 100644
> index 000000000000..37ff7fdfdd3d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/marvell,marvell10g.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/marvell,marvell10g.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell Alaska X 10G Ethernet PHY
> +
> +maintainers:
> + - Tobias Waldekranz <tobias@...dekranz.com>
> +
> +description: |
Do not need '|' unless you need to preserve formatting.
> + Bindings for Marvell Alaska X 10G Ethernet PHYs
Drop Bindings for and describe the hardware. You are repeating title, so
it is useless.
> +
> +allOf:
> + - $ref: ethernet-phy.yaml#
> +
> +properties:
How is this schema selected/applied? I guess you have exactly the same
problem as recently talked about other ethernet PHY bindings.
See:
https://lore.kernel.org/linux-devicetree/20231209014828.28194-1-ansuelsmth@gmail.com/
> + leds:
> + type: object
> +
> + properties:
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
> +
> + patternProperties:
> + '^led@[a-f0-9]+$':
> + $ref: /schemas/leds/common.yaml#
Are you sure you need to repeat all this?
> +
> + properties:
> + marvell,polarity:
> + description: |
> + Electrical polarity and drive type for this LED. In the
> + active state, hardware may drive the pin either low or
> + high. In the inactive state, the pin can either be
> + driven to the opposite logic level, or be tristated.
> + $ref: /schemas/types.yaml#/definitions/string
> + enum:
> + - active-low
> + - active-high
> + - active-low-tristate
> + - active-high-tristate
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ethernet-phy@0 {
> + reg = <0>;
> +
> + marvell,polarity = "active-low-tristate";
It is clearly visible here that your schema is an no-op. You do not
allow such property in the phy, but in leds!
Best regards,
Krzysztof
Powered by blists - more mailing lists