netdev - Re: [PATCH v3 5/5] dt-bindings: net: ipq4019-mdio: Document ipq5332 platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fa2d219-63d7-45cf-9e05-b85dbce24076@linaro.org>
Date: Fri, 15 Dec 2023 11:21:53 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Jie Luo <quic_luoj@...cinc.com>, agross@...nel.org, andersson@...nel.org,
 konrad.dybcio@...aro.org, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, andrew@...n.ch,
 hkallweit1@...il.com, linux@...linux.org.uk, robert.marko@...tura.hr
Cc: linux-arm-msm@...r.kernel.org, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 quic_srichara@...cinc.com
Subject: Re: [PATCH v3 5/5] dt-bindings: net: ipq4019-mdio: Document ipq5332
 platform

On 15/12/2023 11:03, Jie Luo wrote:
>>>>> +  cmn-reference-clock:
>>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>>
>>>> Nothing improved here
>>>
>>> With this change, the warning is not reported when i run
>>> dt_binding_check, looks the new added property needs
>>> the type ref to avoid the warning reported.
>>
>> Nothing improved in the property name, nor its style, nor in the actual
>> contents/values.
> 
> This property is for CMN PLL block reference clock configuration,
> so i use this property name.
> 
> it will be appreciated if you can suggest a suitable name, thanks.

See example-schema about naming. Read writing-bindings. You need vendor
prefix for custom properties.

> 
>>
>> ...
>>
>>>>> +  reset-gpios:
>>>>> +    maxItems: 1
>>>>> +
>>>>> +  reset-assert-us:
>>>>> +    maxItems: 1
>>>>
>>>> This does not look related to ipq5332.
>>>
>>> The reset gpio properties are needed on ipq5332, since qca8084 phy is
>>> connected, which uses the MDIO bus level gpio reset.
>>
>> I am talking about this property, not these properties.
> 
> ok.
> 
>>
>>>
>>> Without declaring these gpio properties, the warning will be reported
>>> by dt_binding_check.
>>
>> How is it even possible to have warnings if there is no such node in
>> DTS? We do not care about warnings in your downstream code.
>>
>>
>> Best regards,
>> Krzysztof
>>
> 
> If i do not declare the property "reset-assert-us" and 
> "reset-deassert-us", the warning will be reported by "make 
> dt_binding_check" since i
> add a example in this file.

This argument does not make sense, sorry. Obviously if property is not
allowed, it should be removed.

Provide rationale, in terms of hardware, why this property must be added
and why it cannot be deduced from the compatible.

Best regards,
Krzysztof