netdev - Re: [PATCH net-next v2 1/8] dpaa2-switch: set interface MAC address only on endpoint change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 15 Dec 2023 11:57:40 +0000
From: Simon Horman <horms@...nel.org>
To: Ioana Ciornei <ioana.ciornei@....com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/8] dpaa2-switch: set interface MAC address
 only on endpoint change

On Wed, Dec 13, 2023 at 02:14:04PM +0200, Ioana Ciornei wrote:
> There is no point in updating the MAC address of a switch interface each
> time the link state changes, this only needs to happen in case the
> endpoint changes (the switch interface is [dis]connected from/to a MAC).
> 
> Just move the call to dpaa2_switch_port_set_mac_addr() under
> DPSW_IRQ_EVENT_ENDPOINT_CHANGED.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>

Reviewed-by: Simon Horman <horms@...nel.org>