netdev - Re: [PATCH net] net/rose: fix races in rose_kill_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <170264222426.21512.10024922314954258007.git-patchwork-notify@kernel.org>
Date: Fri, 15 Dec 2023 12:10:24 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Eric Dumazet <edumazet@...gle.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 netdev@...r.kernel.org, eric.dumazet@...il.com, syzkaller@...glegroups.com,
 f6bvp@...e.fr
Subject: Re: [PATCH net] net/rose: fix races in rose_kill_by_device()

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@...emloft.net>:

On Thu, 14 Dec 2023 15:27:47 +0000 you wrote:
> syzbot found an interesting netdev refcounting issue in
> net/rose/af_rose.c, thanks to CONFIG_NET_DEV_REFCNT_TRACKER=y [1]
> 
> Problem is that rose_kill_by_device() can change rose->device
> while other threads do not expect the pointer to be changed.
> 
> We have to first collect sockets in a temporary array,
> then perform the changes while holding the socket
> lock and rose_list_lock spinlock (in this order)
> 
> [...]

Here is the summary with links:
  - [net] net/rose: fix races in rose_kill_by_device()
    https://git.kernel.org/netdev/net/c/64b8bc7d5f14

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html