netdev - Re: [PATCH v3 5/5] dt-bindings: net: ipq4019-mdio: Document ipq5332 platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e5b6ab5-fc89-4986-894a-62af08343859@quicinc.com>
Date: Fri, 15 Dec 2023 20:55:39 +0800
From: Jie Luo <quic_luoj@...cinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, <agross@...nel.org>,
        <andersson@...nel.org>, <konrad.dybcio@...aro.org>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <andrew@...n.ch>, <hkallweit1@...il.com>, <linux@...linux.org.uk>,
        <robert.marko@...tura.hr>
CC: <linux-arm-msm@...r.kernel.org>, <netdev@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <quic_srichara@...cinc.com>
Subject: Re: [PATCH v3 5/5] dt-bindings: net: ipq4019-mdio: Document ipq5332
 platform



On 12/15/2023 8:14 PM, Krzysztof Kozlowski wrote:
> On 15/12/2023 13:03, Jie Luo wrote:
>>>> If i do not declare the property "reset-assert-us" and
>>>> "reset-deassert-us", the warning will be reported by "make
>>>> dt_binding_check" since i
>>>> add a example in this file.
>>>
>>> This argument does not make sense, sorry. Obviously if property is not
>>> allowed, it should be removed.
>>>
>>> Provide rationale, in terms of hardware, why this property must be added
>>> and why it cannot be deduced from the compatible.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> So i can remove "reset-assert-us" and "reset-deassert-us" from the added
>> example to avoid the dt check warning? even these two properties are
>> needed to be defined in the device tree to make this driver working
>> correctly.
> 
> Sorry, that does not answer my question at all. First, "Driver" is not
> hardware. My second question was simply ignored. In the v2 thread you as
> well respond with some short, unrelated sentences not answering to the
> real questions. It's a waste of my time. Please reach internally in
> Qualcomm for guidance how to upstream patches and how to write bindings.
> 
> Best regards,
> Krzysztof
> 

These properties "reset-assert-us" and "reset-deassert-us" are the
general properties from mdio.yaml, which are used when the MDIO
bus driver is registered by the MDIO framework.
The general DT property already supports to do the correct config,
then compatible string is not needed to be checked for doing the
configs.

i will check the binding examples to avoid this kind of problems.