netdev - Re: [PATCH net 1/2] net: ethernet: cortina: Drop software checksumming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbu_MjJCiC0bCx4EVA7krY=iTvqKyu0ym8n3QuzoPvOhA@mail.gmail.com>
Date: Fri, 15 Dec 2023 15:28:35 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: Hans Ulli Kroll <ulli.kroll@...glemail.com>, "David S. Miller" <davem@...emloft.net>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net 1/2] net: ethernet: cortina: Drop software checksumming

On Fri, Dec 15, 2023 at 10:32 AM Eric Dumazet <edumazet@...gle.com> wrote:

> Depending on packet being gso or not, you would have to check skb->len
> or shinfo->gso_size
>
> The ndo_features_check could then take a more appropriate action
> (forcing GSO, and/or forcing software checksumming)

We had something like that before but it looked weird because
it was just looking at the MTU.

> This driver claims to support TSO, but I do not see it using
> shinfo->gso_size, something must be very wrong...
>
> I would simply remove this TSO part, before the driver really supports
> TSO properly.

I added a hunk dropping the TSO flags for v2. Sending out tomorrow!

Yours,
Linus Walleij