netdev - Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZXyMdd0IjI1Op7a6@localhost.localdomain>
Date: Fri, 15 Dec 2023 18:27:17 +0100
From: Michal Kubiak <michal.kubiak@...el.com>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
CC: Paul Menzel <pmenzel@...gen.mpg.de>, "Hay, Joshua A"
	<joshua.a.hay@...el.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "Fijalkowski, Maciej"
	<maciej.fijalkowski@...el.com>, "Tantilov, Emil S"
	<emil.s.tantilov@...el.com>, "Zaremba, Larysa" <larysa.zaremba@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Lobakin, Aleksander"
	<aleksander.lobakin@...el.com>, "Brady, Alan" <alan.brady@...el.com>,
	"Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

On Wed, Dec 13, 2023 at 03:06:09PM -0800, Tony Nguyen wrote:
> 
> 
> On 12/13/2023 2:22 PM, Nguyen, Anthony L wrote:
> > 
> > 
> > > -----Original Message-----
> > > From: Kubiak, Michal <michal.kubiak@...el.com>
> > > Sent: Wednesday, December 13, 2023 5:51 AM
> > > 
> > > On Wed, Dec 13, 2023 at 02:23:19PM +0100, Michal Kubiak wrote:
> > > > On Tue, Dec 12, 2023 at 05:50:55PM +0100, Paul Menzel wrote:
> > > > > Dear Michal, dear Joshua,
> > > > > 
> > > > > 
> > > > > Thank you for your patch.
> > > > > 
> > > > > On 12/12/23 15:55, Michal Kubiak wrote:
> > > > > > From: Joshua Hay <joshua.a.hay@...el.com>
> > > > > > 
> > > > > > Tell hardware to writeback completed descriptors even when
> > > > > > interrupts
> > > > > 
> > > > > Should you resend, the verb is spelled with a space: write back.
> > > > 
> > > > Sure, I will fix it.
> > > 
> > > Hi Tony,
> > > 
> > > Could you please add a space ("writeback" -> "write back") when taking the
> > > patch to your tree?
> > 
> > Yep, I can do that.
> 
> Actually, looks like you missed updating kdocs
> 
> drivers/net/ethernet/intel/idpf/idpf_txrx.h:508: warning: Function parameter
> or member 'dyn_ctl_intena_msk_m' not described in 'idpf_intr_reg'
> drivers/net/ethernet/intel/idpf/idpf_txrx.h:508: warning: Function parameter
> or member 'dyn_ctl_wb_on_itr_m' not described in 'idpf_intr_reg'
> drivers/net/ethernet/intel/idpf/idpf_txrx.h:561: warning: Function parameter
> or member 'wb_on_itr' not described in 'idpf_q_vector'
> 
> > Thanks,
> > Tony

Thank you, Tony, for reporting that!
So I will fix kdocs and missing space in v2.

Thanks,
Michal