netdev - Re: [patch net-next v7 5/9] genetlink: introduce per-sock family private storage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b214f133-fec6-4814-b77e-86d03ed8756d@intel.com>
Date: Thu, 14 Dec 2023 19:05:30 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jiri Pirko <jiri@...nulli.us>, <netdev@...r.kernel.org>
CC: <kuba@...nel.org>, <pabeni@...hat.com>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <jhs@...atatu.com>, <johannes@...solutions.net>,
	<andriy.shevchenko@...ux.intel.com>, <amritha.nambiar@...el.com>,
	<sdf@...gle.com>, <horms@...nel.org>, <przemyslaw.kitszel@...el.com>
Subject: Re: [patch net-next v7 5/9] genetlink: introduce per-sock family
 private storage



On 12/14/2023 10:15 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
> 
> Introduce an xarray for Generic netlink family to store per-socket
> private. Initialize this xarray only if family uses per-socket privs.
> 
> Introduce genl_sk_priv_get() to get the socket priv pointer for a family
> and initialize it in case it does not exist.
> Introduce __genl_sk_priv_get() to obtain socket priv pointer for a
> family under RCU read lock.
> 
> Allow family to specify the priv size, init() and destroy() callbacks.
> 
> Signed-off-by: Jiri Pirko <jiri@...dia.com>
> ---
> v6->v7:
> - converted family->sock_priv_list to family->sock_privs xarray
>   and use it to store the per-socket privs, use sock pointer as
>   an xarrar index. This made the code much simpler


Yea this version is a lot simpler and seems like it should prevent the
races.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

Thanks,
Jake