netdev - Re: [PATCH V2 net-next 2/3] net: hns3: dump more reg info based on ras mod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ac4a3aa-602a-4bc9-aa73-c6896effefe3@huawei.com>
Date: Sat, 16 Dec 2023 09:37:04 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Simon Horman <horms@...nel.org>
CC: <shaojijie@...wei.com>, <yisen.zhuang@...wei.com>,
	<salil.mehta@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <shenjian15@...wei.com>,
	<wangjie125@...wei.com>, <liuyonglong@...wei.com>, <lanhao@...wei.com>,
	<wangpeiyang1@...wei.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 net-next 2/3] net: hns3: dump more reg info based on
 ras mod


on 2023/12/15 16:01, Simon Horman wrote:
> On Thu, Dec 14, 2023 at 10:11:34PM +0800, Jijie Shao wrote:
>>   #include "hclge_main.h"
>> +#include "hclge_debugfs.h"
> Hi Jijie Shao and Peiyang Wang,
>
> hclge_debugfs.h defines a number of constants, such as hclge_dbg_tqp_reg.
>
> With the above include added, these constants are now also defined
> in files that include hclge_err.h. Which leads to them
> being defined but unused in hclge_main.c.
>
> At a glance, it seems that these constants are only used in hclge_debugfs.c.
> Perhaps they could simply be moved there?
>
Yeah, I also plan to move them to hclge_debugfs.c.
So I'm going to add a patch to the v3 patchset to move them

Thanks,
Jijie