netdev - Re: [net PATCH] i40e: fix use-after-free in i40e_aqc_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3ca71217-4291-45e4-9073-9e32c5177e29@sangfor.com.cn>
Date: Mon, 18 Dec 2023 14:54:49 +0800
From: "xiaoke@...gfor.com.cn" <xiaoke@...gfor.com.cn>
To: Brett Creeley <bcreeley@....com>, jesse.brandeburg@...el.com,
 anthony.l.nguyen@...el.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com
Cc: dinghui@...gfor.com.cn, zhudi2@...wei.com,
 intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [net PATCH] i40e: fix use-after-free in i40e_aqc_add_filters()

On 2023/12/16 1:16, Brett Creeley wrote:
> On 12/13/2023 2:49 AM, Ke Xiao wrote:
>> Caution: This message originated from an External Source. Use proper 
>> caution when opening attachments, clicking links, or responding.
>>
>>
>> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c 
>> b/drivers/net/ethernet/intel/i40e/i40e_main.c
>> index 1ab8dbe2d880..16b574d69843 100644
>> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
>> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
>> @@ -108,11 +108,17 @@ static void netdev_hw_addr_refcnt(struct 
>> i40e_mac_filter *f,
>>                                    struct net_device *netdev, int delta)
>>   {
>>          struct netdev_hw_addr *ha;
>> +       struct netdev_hw_addr_list *ha_list;
> 
> Nit, needs to be in Reverse Christmas Tree (RCT) order.

Thanks, I will send the V2 to follow the rule.