netdev - RE: [EXT] [PATCH] xfrm: Use spin_lock_bh() in xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 18 Dec 2023 11:17:25 +0000
From: Suman Ghosh <sumang@...vell.com>
To: Zhang Yiqun <zhangyiqun@...tium.com.cn>,
        "steffen.klassert@...unet.com"
	<steffen.klassert@...unet.com>,
        "herbert@...dor.apana.org.au"
	<herbert@...dor.apana.org.au>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org"
	<kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] [PATCH] xfrm: Use spin_lock_bh() in xfrm_input()

>diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c index
>bd4ce21d76d7..f4cd46d73b1e 100644
>--- a/net/xfrm/xfrm_input.c
>+++ b/net/xfrm/xfrm_input.c
>@@ -581,7 +581,7 @@ int xfrm_input(struct sk_buff *skb, int nexthdr,
>__be32 spi, int encap_type)
> 		}
>
> lock:
>-		spin_lock(&x->lock);
>+		spin_lock_bh(&x->lock);
[Suman] Hi Zhang,
There is a spin_lock() after label "resume". Don't we need to change it there?
>