netdev - Re: [PATCH v21 06/20] nvme-tcp: Add DDP data-path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 18 Dec 2023 20:47:14 +0200
From: Max Gurtovoy <mgurtovoy@...dia.com>
To: Aurelien Aptel <aaptel@...dia.com>, linux-nvme@...ts.infradead.org,
 netdev@...r.kernel.org, sagi@...mberg.me, hch@....de, kbusch@...nel.org,
 axboe@...com, chaitanyak@...dia.com, davem@...emloft.net, kuba@...nel.org
Cc: Boris Pismenny <borisp@...dia.com>, aurelien.aptel@...il.com,
 smalin@...dia.com, malin1024@...il.com, ogerlitz@...dia.com,
 yorayz@...dia.com, galshalom@...dia.com
Subject: Re: [PATCH v21 06/20] nvme-tcp: Add DDP data-path



On 18/12/2023 20:08, Aurelien Aptel wrote:
> Max Gurtovoy <mgurtovoy@...dia.com> writes:
>>> +
>>> +	if (nvme_tcp_is_ddp_offloaded(req)) {
>>
>> Same optimization here:
>>
>> if (IS_ENABLED(CONFIG_ULP_DDP) && nvme_tcp_is_ddp_offloaded(req)) {
>>
> 
> nvme_tcp_is_ddp_offloaded() compiles to "return false" when ULP_DDP is
> disabled and the compiler already folds the branching completely.
> 
>>
>> if (IS_ENABLED(CONFIG_ULP_DDP) && test_bit(NVME_TCP_Q_OFF_DDP,
>> &queue->flags))
>>
> 
> Same, I've checked and the test is already optimized out.
> 
> Thanks
> 

Ok looks good,

Reviewed-by: Max Gurtovoy <mgurtovoy@...dia.com>