netdev - Re: [PATCH 1/2] net: phy: Add BaseT1 auto-negotiation constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89f68405-2506-420b-952f-a168ebcb4d73@lunn.ch>
Date: Tue, 19 Dec 2023 00:45:01 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Dimitri Fedrau <dima.fedrau@...il.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] net: phy: Add BaseT1 auto-negotiation constants

On Mon, Dec 18, 2023 at 11:18:13PM +0100, Dimitri Fedrau wrote:
> Added constants for advertising 100BT1 and 1000BT1 in register BASE-T1
> auto-negotiation advertisement register [31:16] (Register 7.515)

Hi Dimitri

These two patches look good, but...

Please take a read of:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq

Also, its normal to include a user for new APIs. Do you have a driver
which will make use of this to advertisement modes?

Thanks
	Andrew