netdev - RE: [Intel-wired-lan] [PATCH v2 iwl-next 0/6] ice: fix timestamping in reset process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BL0PR11MB3122E2EF359D73CBEE071233BD90A@BL0PR11MB3122.namprd11.prod.outlook.com>
Date: Mon, 18 Dec 2023 05:40:06 +0000
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To: "Kolacinski, Karol" <karol.kolacinski@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Kolacinski, Karol"
	<karol.kolacinski@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Brandeburg, Jesse"
	<jesse.brandeburg@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH v2 iwl-next 0/6] ice: fix timestamping
 in reset process

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Karol Kolacinski
> Sent: Monday, December 11, 2023 8:32 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Kolacinski, Karol <karol.kolacinski@...el.com>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Brandeburg, Jesse <jesse.brandeburg@...el.com>
> Subject: [Intel-wired-lan] [PATCH v2 iwl-next 0/6] ice: fix timestamping in reset process
>
> PTP reset process has multiple places where timestamping can end up in
> an incorrect state.
>
> This series introduces a proper state machine for PTP and refactors
> a large part of the code to ensure that timestamping does not break.
>
> Jacob Keller (5):
>   ice: pass reset type to PTP reset functions
>   ice: rename verify_cached to has_ready_bitmap
>   ice: rename ice_ptp_tx_cfg_intr
>   ice: factor out ice_ptp_rebuild_owner()
>   ice: stop destroying and reinitalizing Tx tracker during reset
>
>  Karol Kolacinski (1):
>   ice: introduce PTP state machine
>
> V1 -> V2: rebased the series and dropped already merged patches
>
>  drivers/net/ethernet/intel/ice/ice.h         |   1 -
>  drivers/net/ethernet/intel/ice/ice_ethtool.c |   2 +-
>  drivers/net/ethernet/intel/ice/ice_main.c    |   4 +-
>  drivers/net/ethernet/intel/ice/ice_ptp.c     | 226 +++++++++++--------
>  drivers/net/ethernet/intel/ice/ice_ptp.h     |  34 ++-
>  5 files changed, 163 insertions(+), 104 deletions(-)
>
>
> base-commit: 9615a96563f03aef04320cb9b4c33f7bdabac5af
> -- 
> 2.40.1

With ice: fix timestamping in reset process patch series, PTP time sync not happening. Observing missing timestamp on transmitted sync continuously at master side. Without patch series PTP working fine.

Observing below logs when running ptp4l as a master:

#./ptp4l -i eth8 -f configs/default.cfg -m

ptp4l[13259.050]: selected /dev/ptp7 as PTP clock
ptp4l[13259.065]: port 1: INITIALIZING to LISTENING on INIT_COMPLETE
ptp4l[13259.065]: port 0: INITIALIZING to LISTENING on INIT_COMPLETE
ptp4l[13265.651]: port 1: LISTENING to MASTER on ANNOUNCE_RECEIPT_TIMEOUT_EXPIRES
ptp4l[13265.651]: selected local clock 6805ca.fffe.787776 as best master
ptp4l[13265.651]: port 1: assuming the grand master role
ptp4l[13266.652]: missing timestamp on transmitted sync
ptp4l[13266.652]: port 1: MASTER to FAULTY on FAULT_DETECTED (FT_UNSPECIFIED)
ptp4l[13282.654]: port 1: FAULTY to LISTENING on INIT_COMPLETE
ptp4l[13289.267]: port 1: LISTENING to MASTER on ANNOUNCE_RECEIPT_TIMEOUT_EXPIRES
ptp4l[13289.267]: selected local clock 6805ca.fffe.787776 as best master
ptp4l[13289.267]: port 1: assuming the grand master role
ptp4l[13290.268]: missing timestamp on transmitted sync
ptp4l[13290.268]: port 1: MASTER to FAULTY on FAULT_DETECTED (FT_UNSPECIFIED)
ptp4l[13306.269]: port 1: FAULTY to LISTENING on INIT_COMPLETE
ptp4l[13313.261]: port 1: LISTENING to MASTER on ANNOUNCE_RECEIPT_TIMEOUT_EXPIRES
ptp4l[13313.261]: selected local clock 6805ca.fffe.787776 as best master
ptp4l[13313.261]: port 1: assuming the grand master role
ptp4l[13314.262]: missing timestamp on transmitted sync
ptp4l[13314.262]: port 1: MASTER to FAULTY on FAULT_DETECTED (FT_UNSPECIFIED)