netdev - Re: [PATCH RFC net-next 1/2] Add en8811h bindings documentation yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0a9e8da3-5bfe-4d8e-ac76-01ab28e9ce56@linaro.org>
Date: Mon, 18 Dec 2023 09:44:40 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Eric Woudstra <ericwouds@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Andrew Lunn <andrew@...n.ch>,
 Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Frank Wunderlich <frank-w@...lic-files.de>,
 Daniel Golle <daniel@...rotopia.org>, Lucien Jheng
 <lucien.jheng@...oha.com>, Zhi-Jun You <hujy652@...tonmail.com>
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH RFC net-next 1/2] Add en8811h bindings documentation yaml

On 16/12/2023 20:44, Eric Woudstra wrote:
> The en8811h phy can be set with serdes polarity reversed on rx and/or tx.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.

A nit, subject: drop second/last, redundant "bindings documentation
yaml". The "dt-bindings" prefix is already stating that these are
bindings. Quite redundant/useless subject.

> 
> Signed-off-by: Eric Woudstra <ericwouds@...il.com>
> ---
>  .../bindings/net/airoha,en8811h.yaml          | 42 +++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/airoha,en8811h.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/airoha,en8811h.yaml b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml
> new file mode 100644
> index 000000000000..96febd8ed6fa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/airoha,en8811h.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Airoha EN8811H PHY
> +
> +maintainers:
> +  - Someone <someone@...email.com>
> +
> +description:
> +  Bindings for Airoha EN8811H PHY

Drop "Bindings for" and instead describe the hardware. Don't copy the
title, what's the point in this?

> +
> +allOf:
> +  - $ref: ethernet-phy.yaml#
> +
> +properties:
> +  airoha,rx-pol-reverse:
> +    type: boolean
> +    description:
> +      Reverse rx polarity of SERDES.
> +
> +

No, that won't work. Your schema is not being applied. Look at patches
on the mailing list for the phys.

Why do I see multiple patchsets of this?

Best regards,
Krzysztof