lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231219105259.GF811967@kernel.org> Date: Tue, 19 Dec 2023 10:52:59 +0000 From: Simon Horman <horms@...nel.org> To: Lorenzo Bianconi <lorenzo@...nel.org> Cc: netdev@...r.kernel.org, lorenzo.bianconi@...hat.com, nbd@....name, john@...ozen.org, sean.wang@...iatek.com, Mark-MC.Lee@...iatek.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com Subject: Re: [PATCH net] net: ethernet: mtk_wed: fix possible NULL pointer dereference in mtk_wed_wo_queue_tx_clean() On Mon, Dec 18, 2023 at 10:16:11PM +0100, Lorenzo Bianconi wrote: > > On Sun, Dec 17, 2023 at 04:37:40PM +0100, Lorenzo Bianconi wrote: > > > In order to avoid a NULL pointer dereference, check entry->buf pointer before running > > > skb_free_frag in mtk_wed_wo_queue_tx_clean routine. > > > > > > Fixes: 799684448e3e ("net: ethernet: mtk_wed: introduce wed wo support") > > > Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org> > > > > Hi Lorenzo, > > Hi Simon, > > > > > can I clarify that this can actually happen? > > I was able to trigger the crash on a real device (Banana Pi BPI-R4) but > with a wrong swiotlb configuration. I do not have a strong opinion, I am > fine to target net-next instead. What do you prefer? I also don't have a strong opinion here. But lean towards 'net' if you were able to trigger a crash. > > Regards, > Lorenzo > > > What I am getting at, is that if not, it might be net-next material. > > In either case, I have no objection to the change itself. > > > > Reviewed-by: Simon Horman <horms@...nel.org>
Powered by blists - more mailing lists