lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231219114701.5r5qoqkekfbvqtcy@skbuf> Date: Tue, 19 Dec 2023 13:47:01 +0200 From: Vladimir Oltean <vladimir.oltean@....com> To: Larysa Zaremba <larysa.zaremba@...el.com> Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, linux-kernel@...r.kernel.org, Randy Dunlap <rdunlap@...radead.org>, Tony Nguyen <anthony.l.nguyen@...el.com>, Björn Töpel <bjorn@...nel.org>, Magnus Karlsson <magnus.karlsson@...el.com>, Maciej Fijalkowski <maciej.fijalkowski@...el.com>, Jonathan Lemon <jonathan.lemon@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Jesper Dangaard Brouer <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com> Subject: Re: [PATCH net-next] xsk: make struct xsk_cb_desc available outside CONFIG_XDP_SOCKETS On Tue, Dec 19, 2023 at 12:26:50PM +0100, Larysa Zaremba wrote: > On Tue, Dec 19, 2023 at 01:02:05PM +0200, Vladimir Oltean wrote: > > The ice driver fails to build when CONFIG_XDP_SOCKETS is disabled. > > > > drivers/net/ethernet/intel/ice/ice_base.c:533:21: error: > > variable has incomplete type 'struct xsk_cb_desc' > > struct xsk_cb_desc desc = {}; > > ^ > > include/net/xsk_buff_pool.h:15:8: note: > > forward declaration of 'struct xsk_cb_desc' > > struct xsk_cb_desc; > > ^ > > > > Fixes: d68d707dcbbf ("ice: Support XDP hints in AF_XDP ZC mode") > > Closes: https://lore.kernel.org/netdev/8b76dad3-8847-475b-aa17-613c9c978f7a@infradead.org/ > > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com> > > This probably should go through bpf-next. Other than that, fix looks fine: > > Acked-by: Larysa Zaremba <larysa.zaremba@...el.com> > > > --- > > Posting to net-next since this tree is broken at this stage, not only > > bpf-next. It was a conscious decision. Build fixes are more time critical than most other patches, and net-next is more likely to suffer from a failure with CONFIG_XDP_SOCKETS disabled than bpf-next is. But, sure, it's up to maintainers to figure out how to deal with it.
Powered by blists - more mailing lists