netdev - Re: [PATCH net-next] net: pktgen: Use wait_event_freezable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38f6b7856f8060f9770ec0ea2a163c5960d9eed9.camel@redhat.com>
Date: Tue, 19 Dec 2023 13:37:23 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Kevin Hao <haokexin@...il.com>, "David S. Miller" <davem@...emloft.net>,
  Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, "Rafael J. Wysocki" <rafael@...nel.org>, Pavel
	Machek <pavel@....cz>
Subject: Re: [PATCH net-next] net: pktgen: Use
 wait_event_freezable_timeout() for freezable kthread

On Sat, 2023-12-16 at 19:26 +0800, Kevin Hao wrote:
> A freezable kernel thread can enter frozen state during freezing by
> either calling try_to_freeze() or using wait_event_freezable() and its
> variants. So for the following snippet of code in a kernel thread loop:
>   wait_event_interruptible_timeout();
>   try_to_freeze();
> 
> We can change it to a simple wait_event_freezable_timeout() and then
> eliminate a function call.
> 
> Signed-off-by: Kevin Hao <haokexin@...il.com>
> ---
>  net/core/pktgen.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/net/core/pktgen.c b/net/core/pktgen.c
> index 57cea67b7562..2b59fc66fe26 100644
> --- a/net/core/pktgen.c
> +++ b/net/core/pktgen.c
> @@ -3669,10 +3669,8 @@ static int pktgen_thread_worker(void *arg)
>  		if (unlikely(!pkt_dev && t->control == 0)) {
>  			if (t->net->pktgen_exiting)
>  				break;
> -			wait_event_interruptible_timeout(t->queue,
> -							 t->control != 0,
> -							 HZ/10);
> -			try_to_freeze();
> +			wait_event_freezable_timeout(t->queue,
> +						     t->control != 0, HZ/10);

The patch looks functionally correct to me, so I'm sorry to nit-pick. 

Since you touch the last line just for a 'cosmetic' change, please make
checkpatch happy, too:  please replace 'HZ/10' with 'HZ / 10'.

Thanks!

Paolo