netdev - Re: [PATCH net v2 1/2] net: ethernet: cortina: Drop software checksum and TSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYu9gisMg6b60NZos5atLSifRJj12+q4w3+hMWD6mWtYg@mail.gmail.com>
Date: Tue, 19 Dec 2023 15:24:31 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Hans Ulli Kroll <ulli.kroll@...glemail.com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net v2 1/2] net: ethernet: cortina: Drop software checksum
 and TSO

On Tue, Dec 19, 2023 at 12:23 AM Jakub Kicinski <kuba@...nel.org> wrote:
> On Sat, 16 Dec 2023 20:36:52 +0100 Linus Walleij wrote:

> > -             NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM | \
> > -             NETIF_F_TSO | NETIF_F_TSO_ECN | NETIF_F_TSO6)
> > +            NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM )
>
> nit: checkpatch is really upset about this space before )

I'll fix it, Eric and Maxime opened up the idea of a generic helper to
extract the ethertype from a buffer, so I'll fix this in the next iteration.

Yours,
Linus Walleij