netdev - Re: [PATCH RESEND v2 net-next 06/12] tcp: Link bhash2 to bhash.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 19 Dec 2023 16:24:47 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH RESEND v2 net-next 06/12] tcp: Link bhash2 to bhash.

On Tue, Dec 19, 2023 at 1:21 AM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> bhash2 added a new member sk_bind2_node in struct sock to link
> sockets to bhash2 in addition to bhash.
>
> bhash is still needed to search conflicting sockets efficiently
> from a port for the wildcard address.  However, bhash itself need
> not have sockets.
>
> If we link each bhash2 bucket to the corresponding bhash bucket,
> we can iterate the same set of the sockets from bhash2 via bhash.
>
> This patch links bhash2 to bhash only, and the actual use will be
> in the later patches.  Finally, we will remove sk_bind2_node.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>