netdev - Re: [PATCH RESEND v2 net-next 08/12] tcp: Iterate tb->bhash2 in inet_csk_bind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJTeq9DvFH49WNksy6KLxYV54yeBX+BhL9-qbxreKVCgw@mail.gmail.com>
Date: Tue, 19 Dec 2023 16:27:55 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH RESEND v2 net-next 08/12] tcp: Iterate tb->bhash2 in inet_csk_bind_conflict().

On Tue, Dec 19, 2023 at 1:22 AM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> Sockets in bhash are also linked to bhash2, but TIME_WAIT sockets
> are linked separately in tb2->deathrow.
>
> Let's replace tb->owners iteration in inet_csk_bind_conflict() with
> two iterations over tb2->owners and tb2->deathrow.
>
> This can be done safely under bhash's lock because socket insertion/
> deletion in bhash2 happens with bhash's lock held.
>
> Note that twsk_for_each_bound_bhash() will be removed later.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>